linux-kernel - Re: [PATCH v2] iommu/amd: Fix interrupt remapping when disable guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628090713.GC14532@8bytes.org>
Date:   Wed, 28 Jun 2017 11:07:13 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH v2] iommu/amd: Fix interrupt remapping when disable
 guest_mode

Hi Suravee,

On Mon, Jun 26, 2017 at 04:28:04AM -0500, Suravee Suthikulpanit wrote:
> Pass-through devices to VM guest can get updated IRQ affinity
> information via irq_set_affinity() when not running in guest mode.
> Currently, AMD IOMMU driver in GA mode ignores the updated information
> if the pass-through device is setup to use vAPIC regardless of guest_mode.
> This could cause invalid interrupt remapping.
> 
> Also, the guest_mode bit should be set and cleared only when
> SVM updates posted-interrupt interrupt remapping information.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> Cc: Joerg Roedel <jroedel@...e.de>

Can you please provide a 'Fixes:' tag too? No need to resend the whole
patch, just reply with the tag and I'll add it when applying this patch.


Thanks,

	Joerg