[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628101603.GH14532@8bytes.org>
Date: Wed, 28 Jun 2017 12:16:03 +0200
From: Joerg Roedel <joro@...tes.org>
To: Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc: iommu@...ts.linux-foundation.org,
LKML <linux-kernel@...r.kernel.org>,
David Woodhouse <dwmw2@...radead.org>,
"Liu, Yi L" <yi.l.liu@...el.com>,
Lan Tianyu <tianyu.lan@...el.com>,
"Tian, Kevin" <kevin.tian@...el.com>,
Raj Ashok <ashok.raj@...el.com>,
Alex Williamson <alex.williamson@...hat.com>,
Jean Delvare <khali@...ux-fr.org>
Subject: Re: [PATCH 5/9] iommu: Introduce fault notifier API
On Tue, Jun 27, 2017 at 12:47:59PM -0700, Jacob Pan wrote:
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index d973555..07cfd92 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -48,6 +48,7 @@ struct iommu_group {
> struct list_head devices;
> struct mutex mutex;
> struct blocking_notifier_head notifier;
> + struct blocking_notifier_head fault_notifier;
Do you really need a notifier chain here? Will there ever be more than
one callback registered to it?
> +struct iommu_fault_event {
> + struct device *dev;
Putting a 'struct device *' member in a uapi struct looks fundamentally
wrong.
Joerg
Powered by blists - more mailing lists