[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170628102854.GC11053@arm.com>
Date: Wed, 28 Jun 2017 11:28:54 +0100
From: Will Deacon <will.deacon@....com>
To: Borislav Petkov <bp@...e.de>
Cc: Arnd Bergmann <arnd@...db.de>,
Tyler Baicar <tbaicar@...eaurora.org>,
Xie XiuQi <xiexiuqi@...wei.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ras: mark stub functions as 'inline'
On Wed, Jun 28, 2017 at 12:27:44PM +0200, Borislav Petkov wrote:
> On Tue, Jun 27, 2017 at 05:35:41PM +0200, Arnd Bergmann wrote:
> > With CONFIG_RAS disabled, we get two harmless warnings about
> > unused functions:
> >
> > include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function]
> > static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
> > include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function]
> > static void log_non_standard_event(const guid_t *sec_type,
> >
> > Clearly these are meant to be 'inline', like the other stubs
> > in the same header.
> >
> > Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
> > Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> > include/linux/ras.h | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
>
> Acked-by: Borislav Petkov <bp@...e.de>
>
> I'm assuming Will is picking this one up along with the rest of the ARM
> RAS pile...
Yup, will do. Thanks.
Will
Powered by blists - more mailing lists