linux-kernel - Re: [PATCH] staging: rts5208 : Fixing coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628125809.GA30378@kroah.com>
Date:   Wed, 28 Jun 2017 14:58:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Simo Koskinen <koskisoft@...il.com>
Cc:     wporter82@...il.com, dilekuzulmez@...il.com,
        bankarsandhya512@...il.com, colin.king@...onical.com,
        quexint@...il.com, sergio.paracuellos@...il.com,
        jrickertkc@...il.com, julia.lawall@...6.fr,
        namrataashettar@...il.com, arushisinghal19971997@...il.com,
        baijiaju1990@....com, aquannie@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208 : Fixing coding style warnings

On Wed, Jun 28, 2017 at 02:50:12PM +0200, Simo Koskinen wrote:
> Fixed following warnings found by checkpatch.pl script:
> 
> WARNING: Prefer using '"%s...", __func__' to using 'xxxx',
> this function's name, in a string
> 
> Signed-off-by: Simo Koskinen <koskisoft@...il.com>

Is this different from a previous patch?  If so, you need to properly
version your patch, as the documentation descripts how to do.

> ---
>  drivers/staging/rts5208/rtsx.c      |  2 --
>  drivers/staging/rts5208/rtsx_chip.c |  4 ++--
>  drivers/staging/rts5208/sd.c        |  8 ++++----
>  drivers/staging/rts5208/spi.c       |  8 ++++----
>  drivers/staging/rts5208/xd.c        | 11 ++++++-----
>  5 files changed, 16 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index b8177f5..c7ae702 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -1009,8 +1009,6 @@ static void rtsx_remove(struct pci_dev *pci)
>  {
>  	struct rtsx_dev *dev = pci_get_drvdata(pci);
>  
> -	dev_info(&pci->dev, "rtsx_remove() called\n");
> -

This change does not match up with the changelog text :(