[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1706281532400.1970@nanos>
Date: Wed, 28 Jun 2017 15:33:25 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Dmitry Vyukov <dvyukov@...gle.com>
cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Peter Zijlstra <peterz@...radead.org>,
Will Deacon <will.deacon@....com>,
"H. Peter Anvin" <hpa@...or.com>,
Andrey Ryabinin <aryabinin@...tuozzo.com>,
kasan-dev <kasan-dev@...glegroups.com>,
"x86@...nel.org" <x86@...nel.org>,
LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] locking/atomics: don't alias ____ptr
On Wed, 28 Jun 2017, Dmitry Vyukov wrote:
> On Wed, Jun 28, 2017 at 2:24 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > On Wed, 28 Jun 2017, Dmitry Vyukov wrote:
> >> On Wed, Jun 28, 2017 at 1:10 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> >> > #define cmpxchg_local(ptr, old, new) \
> >> > ({ \
> >> > - __typeof__(ptr) ____ptr = (ptr); \
> >> > - kasan_check_write(____ptr, sizeof(*____ptr)); \
> >> > - arch_cmpxchg_local(____ptr, (old), (new)); \
> >> > + kasan_check_write((ptr), sizeof(*(ptr))); \
> >> > + arch_cmpxchg_local((ptr), (old), (new)); \
> >>
> >>
> >> /\/\/\/\/\/\/\/\/\/\/\/\
> >>
> >> These are macros.
> >> If ptr is foo(), then we will call foo() twice.
> >
> > If that's true, the foo() will be evaluated a gazillion more times down the
> > way to the end of this macro maze.
>
> No. If we do:
>
> __typeof__(ptr) ____ptr = (ptr);
>
> and then only use ____ptr, then ptr is evaluated only once regardless
> of what the rest of macros do.
What I meant is, that we have today nested macros which do a lot of that
same nonsense even w/o that patch.
Thanks,
tglx
Powered by blists - more mailing lists