[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGh=XABghZ73=TNToMvpQWXP26dS1W8iujj1uQtOB8ewf+Mpew@mail.gmail.com>
Date: Wed, 28 Jun 2017 10:56:03 -0400
From: Al Cooper <al.cooper@...adcom.com>
To: David Laight <David.Laight@...lab.com>
Cc: Al Cooper <alcooperx@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Felipe Balbi <balbi@...nel.org>,
yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>,
Florian Fainelli <f.fainelli@...il.com>,
"open list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"bcm-kernel-feedback-list@...adcom.com"
<bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH 4/8] usb: bdc: Small code cleanup
On Wed, Jun 28, 2017 at 4:47 AM, David Laight <David.Laight@...lab.com> wrote:
>>
>> temp = bdc_readl(bdc->regs, BDC_BDCSC);
>> if ((temp & BDC_P64) &&
>> !dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) {
>> - dev_dbg(bdc->dev, "Using 64-bit address\n");
>> + dev_dbg(dev, "Using 64-bit address\n");
>> } else {
>> - ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
>> + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
>
> That just wrong...
> Or was wrong before.
Why is this wrong?
Al
Powered by blists - more mailing lists