linux-kernel - Re: [PATCH] fbcon: Make fbcon a built-time depency for fbdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628110819.70eb0ce0@gandalf.local.home>
Date:   Wed, 28 Jun 2017 11:08:19 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alan Cox <alan@...rguk.ukuu.org.uk>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        dri-devel@...ts.freedesktop.org,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH] fbcon: Make fbcon a built-time depency for fbdev

On Wed, 28 Jun 2017 12:36:35 +0200
Daniel Vetter <daniel.vetter@...ll.ch> wrote:

> There's a bunch of folks who're trying to make printk less
> contended and faster, but there's a problem: printk uses the
> console_lock, and the console lock has become the BKL for all things
> fbdev/fbcon, which in turn pulled in half the drm subsystem under that
> lock. That's awkward.
> 

I applied your patch and compiled it, and got this error while
installing modules:

  DEPMOD  4.12.0-rc5-test+
depmod: ERROR: Found 11 modules in dependency cycles!
depmod: ERROR: Cycle detected: fbcon -> bitblit -> softcursor -> fb -> fbcon
depmod: ERROR: Cycle detected: softcursor -> fb -> fbcon_rotate -> fbcon_ccw -> softcursor
depmod: ERROR: Cycle detected: fb -> fbcon_rotate -> fbcon_ccw -> fb
depmod: ERROR: Cycle detected: softcursor -> fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> softcursor
depmod: ERROR: Cycle detected: fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fb
depmod: ERROR: Cycle detected: softcursor -> fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fbcon_cw -> softcursor
depmod: ERROR: Cycle detected: fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fbcon_cw -> fb
depmod: ERROR: Cycle detected: fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fbcon_cw -> fb
depmod: ERROR: Cycle detected: fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fbcon_cw -> tileblit -> fb
depmod: ERROR: Cycle detected: fbcon -> bitblit -> softcursor -> fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fbcon_cw -> tileblit -> fbdev
depmod: ERROR: Cycle detected: fb -> fbcon_rotate -> fbcon_ccw -> fbcon_ud -> fbcon_cw -> tileblit -> fb
/work/git/linux-trace.git/Makefile:1251: recipe for target '_modinst_post' failed


Config attached.

Oh, and I changed CONFIG_FB to be a module, which is probably where the
error happened.

-- Steve

Download attachment "config" of type "application/octet-stream" (122059 bytes)