linux-kernel - Re: [PATCH] selftests: ftrace: Use md5sum to take less time of checking logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97100897-9bd4-11e0-79a5-faea8ba22a09@kernel.org>
Date:   Wed, 28 Jun 2017 09:30:55 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kselftest@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests: ftrace: Use md5sum to take less time of
 checking logs

On 06/28/2017 08:59 AM, Steven Rostedt wrote:
> On Wed, 28 Jun 2017 08:30:24 -0600
> Shuah Khan <shuah@...nel.org> wrote:
> 
>> On 06/28/2017 08:17 AM, Steven Rostedt wrote:
>>> On Tue, 27 Jun 2017 19:28:32 +0900
>>> Masami Hiramatsu <mhiramat@...nel.org> wrote:
>>>   
>>>> Use md5sum so that it takes less time of checking
>>>> trace logs update. Since busybox tail/cat takes too
>>>> long time to read the trace log, this uses md5sum
>>>> to check whether trace log is updated or not.  
>>>
>>> How much faster is md5sum? I can see this causing issues in other
>>> environments.
>>>
>>> -- Steve  
>>
>> Sorry Steve. I pulled this into linux-ksefltest next. Are you concerned
>> about any specific environments? I can try this out and see if it is a
>> problem.
> 
> Yes please. I should probably do some playing too. I would like to fix
> that test anyway, as it is one of the longer ones as I do a lot of
> "paranoid checks". That is, I may go overboard in testing if tracing is
> off or not, by checking to make sure its off using different tactics.
> 

Please let me know how your trials go. I have a few things I have to get
to before I get around to trying this patch.

thanks,
-- Shuah