[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628161354.GB5316@codeaurora.org>
Date: Wed, 28 Jun 2017 09:13:54 -0700
From: Stephen Boyd <sboyd@...eaurora.org>
To: Andreas Färber <afaerber@...e.de>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Satoru OKAMOTO <okamoto.satoru@...ionext.com>,
Michael Turquette <mturquette@...libre.com>,
linux-clk@...r.kernel.org, Jassi Brar <jaswinder.singh@...aro.org>,
Andy Green <andy.green@...aro.org>,
Vincent Yang <vincent.yang@...ionext.com>,
Tetsuya Nuriya <nuriya.tetsuya@...ionext.com>
Subject: Re: [PATCH 1/5] clk: mb86s7x: Suppress build
On 06/25, Andreas Färber wrote:
> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol:
>
> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No such file or directory
> #include <soc/mb86s7x/scb_mhu.h>
> ^~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
>
> And when commenting out that line, we get:
>
> drivers/clk/clk-mb86s7x.c: In function 'crg_gate_control':
> drivers/clk/clk-mb86s7x.c:72:8: error: implicit declaration of function 'mb86s7x_send_packet' [-Werror=implicit-function-declaration]
> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ,
> ^~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:72:28: error: 'CMD_PERI_CLOCK_GATE_SET_REQ' undeclared (first use in this function)
> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:72:28: note: each undeclared identifier is reported only once for each function it appears in
> drivers/clk/clk-mb86s7x.c: In function 'crg_rate_control':
> drivers/clk/clk-mb86s7x.c:116:10: error: 'CMD_PERI_CLOCK_RATE_SET_REQ' undeclared (first use in this function)
> code = CMD_PERI_CLOCK_RATE_SET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:121:10: error: 'CMD_PERI_CLOCK_RATE_GET_REQ' undeclared (first use in this function); did you mean 'CMD_PERI_CLOCK_RATE_SET_REQ'?
> code = CMD_PERI_CLOCK_RATE_GET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> CMD_PERI_CLOCK_RATE_SET_REQ
> drivers/clk/clk-mb86s7x.c: In function 'mhu_cluster_rate':
> drivers/clk/clk-mb86s7x.c:276:10: error: 'CMD_CPU_CLOCK_RATE_GET_REQ' undeclared (first use in this function)
> code = CMD_CPU_CLOCK_RATE_GET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/clk/clk-mb86s7x.c:278:10: error: 'CMD_CPU_CLOCK_RATE_SET_REQ' undeclared (first use in this function); did you mean 'CMD_CPU_CLOCK_RATE_GET_REQ'?
> code = CMD_CPU_CLOCK_RATE_SET_REQ;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> CMD_CPU_CLOCK_RATE_GET_REQ
> cc1: some warnings being treated as errors
> scripts/Makefile.build:302: recipe for target
> 'drivers/clk/clk-mb86s7x.o' failed
> make[2]: *** [drivers/clk/clk-mb86s7x.o] Error 1
>
> Comment it out in the Makefile for now.
>
Why not delete the whole driver instead? It's been two years and
the driver has never compiled.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Powered by blists - more mailing lists