linux-kernel - Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 11:20:55 -0500
From:   Suman Anna <s-anna@...com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     Ohad Ben-Cohen <ohad@...ery.com>, Arnd Bergmann <arnd@...db.de>,
        <linux-remoteproc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for
 ARM configs

On 06/27/2017 06:40 PM, Bjorn Andersson wrote:
> On Tue 27 Jun 15:46 PDT 2017, Suman Anna wrote:
> 
>> Drop the dependency on RESET_CONTROLLER for the Keystone remoteproc
>> driver to resolve some circular dependencies around different choices
>> for RESET_CONTROLLER on common ARM configs. This dependency is
>> inherent as the RESET_CONTROLLER will be enabled due to the enabled
>> ARCH_HAS_RESET_CONTROLLER for ARCH_KEYSTONE.
>>
> 
> As my approach requires synchronized changes to rproc-next and
> rpmsg-next and we're close to the merge window I'll pick this
> "workaround" for now, thanks!
> 
> I do think it's appropriate for the Keystone remoteproc driver to
> express its dependency on reset-controller, so I intend to revert this
> as I look into this issue after -rc1 again.
> 
> Merged all 4 patches.

Great, thanks.

regards
Suman

> 
> Regards,
> Bjorn
> 
>> Signed-off-by: Suman Anna <s-anna@...com>
>> ---
>>  drivers/remoteproc/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index 945c1574f896..8891a8e50f12 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -70,7 +70,6 @@ config DA8XX_REMOTEPROC
>>  config KEYSTONE_REMOTEPROC
>>  	tristate "Keystone Remoteproc support"
>>  	depends on ARCH_KEYSTONE
>> -	depends on RESET_CONTROLLER
>>  	select RPMSG_VIRTIO
>>  	help
>>  	  Say Y here here to support Keystone remote processors (DSP)
>> -- 
>> 2.13.1
>>