[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170628192526.2b7e4958@griffin>
Date: Wed, 28 Jun 2017 19:25:26 +0200
From: Jiri Benc <jbenc@...hat.com>
To: Matthias Schiffer <mschiffer@...verse-factory.net>
Cc: davem@...emloft.net, roopa@...ulusnetworks.com, pshelar@....org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] vxlan: add back error messages to
vxlan_config_validate() as extended netlink acks
On Tue, 27 Jun 2017 22:47:58 +0200, Matthias Schiffer wrote:
> if ((conf->flags & ~VXLAN_F_ALLOWED_GPE) ||
> !(conf->flags & VXLAN_F_COLLECT_METADATA)) {
> + NL_SET_ERR_MSG(extack,
> + "unsupported combination of extensions");
Since we're redesigning this, let's be more helpful to the user.
There's probably not going to be tremendous improvements here but let's
try at least a bit.
"VXLAN GPE does not support this combination of extensions"
> if (local_type & IPV6_ADDR_LINKLOCAL) {
> if (!(remote_type & IPV6_ADDR_LINKLOCAL) &&
> - (remote_type != IPV6_ADDR_ANY))
> + (remote_type != IPV6_ADDR_ANY)) {
> + NL_SET_ERR_MSG(extack,
> + "invalid combination of address scopes");
"invalid combination of local and remote address scopes"
> return -EINVAL;
> + }
>
> conf->flags |= VXLAN_F_IPV6_LINKLOCAL;
> } else {
> if (remote_type ==
> - (IPV6_ADDR_UNICAST | IPV6_ADDR_LINKLOCAL))
> + (IPV6_ADDR_UNICAST | IPV6_ADDR_LINKLOCAL)) {
> + NL_SET_ERR_MSG(extack,
> + "invalid combination of address scopes");
ditto
The rest looks good to me. Thanks a lot for doing the work, Matthias!
Jiri
Powered by blists - more mailing lists