[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628181013.pv2f7acbckgnsnhg@rob-hp-laptop>
Date: Wed, 28 Jun 2017 13:10:13 -0500
From: Rob Herring <robh@...nel.org>
To: Bich HEMON <bich.hemon@...com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mark Rutland <mark.rutland@....com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre TORGUE <alexandre.torgue@...com>,
Jiri Slaby <jslaby@...e.com>,
"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 14/20] dt-bindings: serial: document option wake-up
interrupt for STM32 USART
On Mon, Jun 26, 2017 at 12:49:15PM +0000, Bich HEMON wrote:
> From: Bich Hemon <bich.hemon@...com>
>
> Introduce new compatibles for "st,stm32h7-usart" and "st,stm32h7-uart".
> This new compatible allow to use optional wake-up interrupt.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
> ---
> .../devicetree/bindings/serial/st,stm32-usart.txt | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> index a229b14..3b42138 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> @@ -2,11 +2,14 @@
>
> Required properties:
> - compatible: Can be either "st,stm32-usart", "st,stm32-uart",
> -"st,stm32f7-usart" or "st,stm32f7-uart" depending on whether
> -the device supports synchronous mode and is compatible with
> -stm32(f4) or stm32f7.
> +"st,stm32f7-usart", "st,stm32f7-uart", "st,stm32h7-usart" or
> +st,stm32h7-uart depending on whether the device supports synchronous
> +mode and is compatible with stm32(f4), stm32f7 or stm32h7.
Please reformat as 1 valid set of compatibles per line.
> - reg: The address and length of the peripheral registers space
> -- interrupts: The interrupt line of the USART instance
> +- interrupts or interrupts-extended: Must contain first, the interrupt
> + line specifier for the USART instance. An optional wake-up interrupt
> + specifier can be added. Then, -extended variant may be needed to specify
> + interrupts parent controllers.
Just describe the interrupts property and what the interrupts are.
interrupts-extended is implied if it is necessary.
> - clocks: The input clock of the USART instance
>
> Optional properties:
> @@ -53,3 +56,12 @@ usart1: serial@...11000 {
> <&dma2 7 4 0x414 0x0>;
> dma-names = "rx", "tx";
> };
> +
> +uart4: serial@...10000 {
> + compatible = "st,stm32h7-uart";
> + reg = <0x40010000 0x400>;
> + interrupts-extended = <&intc GIC_SPI 52 IRQ_TYPE_NONE>,
> + <&aiec 30 1>;
> + clocks = <&rcc UART4_K>;
> + status = "disabled";
> +};
> --
> 1.9.1
Powered by blists - more mailing lists