linux-kernel - Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628183141.GA12722@lst.de>
Date:   Wed, 28 Jun 2017 20:31:41 +0200
From:   Christoph Hellwig <hch@....de>
To:     Keith Busch <keith.busch@...el.com>
Cc:     wenxiong@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
        axboe@...com, bjking@...ux.vnet.ibm.com, hch@....de
Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF
        enabled

On Wed, Jun 28, 2017 at 01:10:31PM -0400, Keith Busch wrote:
> On Wed, Jun 28, 2017 at 11:32:51AM -0500, wenxiong@...ux.vnet.ibm.com wrote:
> > diff --git a/fs/block_dev.c b/fs/block_dev.c
> > index 519599d..e871444 100644
> > --- a/fs/block_dev.c
> > +++ b/fs/block_dev.c
> > @@ -264,6 +264,10 @@ static void blkdev_bio_end_io_simple(struct bio *bio)
> >  
> >  	if (unlikely(bio.bi_error))
> >  		return bio.bi_error;
> > +
> > +	if (bio_integrity(&bio))
> > +		bio_integrity_free(&bio);
> > +
> >  	return ret;
> >  }
> 
> We don't want to leak the integrity payload in case of bi_error either.

And we should just call __bio_free.  Which btw every user of bio_init
probably needs.