[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk>
Date: Wed, 28 Jun 2017 19:45:07 +0100
From: Mark Brown <broonie@...nel.org>
To: Aravind Thokala <aravind.thk@...il.com>
Cc: Florian Fainelli <f.fainelli@...il.com>,
bcm-kernel-feedback-list@...adcom.com, linux-spi@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
This isn't a good changelog, what are the warnings and why are we fixing
them? The fact that checkpatch complains isn't meaningful in and of
itself - it's OK to say that checkpatch helped identify issues but it's
not perfect and we need to understand what is being changed and why.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists