[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170628201032.3178691-1-arnd@arndb.de>
Date: Wed, 28 Jun 2017 22:10:13 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Saeed Mahameed <saeedm@...lanox.com>,
Matan Barak <matanb@...lanox.com>,
Leon Romanovsky <leonro@...lanox.com>
Cc: Arnd Bergmann <arnd@...db.de>,
"David S. Miller" <davem@...emloft.net>,
Erez Shitrit <erezsh@...lanox.com>,
Thomas Gleixner <tglx@...utronix.de>,
Or Gerlitz <ogerlitz@...lanox.com>,
Christopher Covington <cov@...eaurora.org>,
Ilan Tayari <ilant@...lanox.com>,
Nicolas Pitre <nicolas.pitre@...aro.org>,
netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] [net-next] net/mlx5e: select CONFIG_MLXFW
With the introduction of mlx5 firmware flash support, we get a link
error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y:
drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function `mlx5_firmware_flash':
fw.c:(.text+0x9d4): undefined reference to `mlxfw_firmware_flash'
We could have a more elaborate method to force MLX5 to be a loadable
module in this case, but the easiest fix seems to be to always enable
MLXFW as well, like we do for CONFIG_MLXSW_SPECTRUM, which is the other
user of mlxfw_firmware_flash.
Fixes: 3ffaabecd1a1 ("net/mlx5e: Support the flash device ethtool callback")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
index cf1ef48bfd8d..09edee060b03 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
@@ -6,6 +6,7 @@ config MLX5_CORE
tristate "Mellanox Technologies ConnectX-4 and Connect-IB core driver"
depends on MAY_USE_DEVLINK
depends on PCI
+ select MLXFW
default n
---help---
Core driver for low level functionality of the ConnectX-4 and
--
2.9.0
Powered by blists - more mailing lists