linux-kernel - Re: [PATCH] scsi: ibmvscsi: constify dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a71efdaf-78d0-9a36-c358-3c2719dbcdec@linux.vnet.ibm.com>
Date:   Thu, 29 Jun 2017 15:38:30 -0700
From:   Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        tyreld@...ux.vnet.ibm.com, benh@...nel.crashing.org,
        paulus@...ba.org, mpe@...erman.id.au, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ibmvscsi: constify dev_pm_ops structures.

On 06/29/2017 12:43 AM, Arvind Yadav wrote:
> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   17956	   1456	      8	  19420	   4bdc	drivers/scsi/ibmvscsi/ibmvscsi.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   18164	   1264	      8	  19436	   4bec	drivers/scsi/ibmvscsi/ibmvscsi.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Acked-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>