linux-kernel - Re: [linux-next][PATCH] usb: dwc3: omap: remove IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629060353.GE3730@atomide.com>
Date:   Wed, 28 Jun 2017 23:03:53 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Vignesh R <vigneshr@...com>
Cc:     "Strashko, Grygorii" <grygorii.strashko@...com>,
        "GregKroah-Hartmangregkh@...uxfoundation.org" 
        <GregKroah-Hartmangregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Nori, Sekhar" <nsekhar@...com>
Subject: Re: [linux-next][PATCH] usb: dwc3: omap: remove IRQ_NOAUTOEN used
 with shared irq

* Vignesh R <vigneshr@...com> [170628 21:21]:
> 
> 
> On Thursday 29 June 2017 05:01 AM, Strashko, Grygorii wrote:
> > IRQ_NOAUTOEN can't be used with shared IRQs and Kernel now will triggers
> > warning if it happns, since commit 04c848d39879 ("genirq: Warn when
> > IRQ_NOAUTOEN is used with shared interrupts"). And this is the case for
> > OMAP DWC 3 driver.
> > 
> > Hence, remove IRQ_NOAUTOEN flag and instead call disable_irq() before
> > disabling PM runtime in probe error path handling.
> 
> Or, how about requesting the irq at the end of probe after extcon
> registration?

Hmm yeah, what prevents the issue that we tried to fix with commit
12a7f17fac5b ("usb: dwc3: omap: fix race of pm runtime with irq handler
in probe")?

Regards,

Tony


> > Fixes: 12a7f17fac5b ("usb: dwc3: omap: fix race of pm runtime with...")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> > ---
> >  drivers/usb/dwc3/dwc3-omap.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> > index 9892650..cd9bef5 100644
> > --- a/drivers/usb/dwc3/dwc3-omap.c
> > +++ b/drivers/usb/dwc3/dwc3-omap.c
> > @@ -512,7 +512,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
> >  
> >  	/* check the DMA Status */
> >  	reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
> > -	irq_set_status_flags(omap->irq, IRQ_NOAUTOEN);
> >  	ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt,
> >  					dwc3_omap_interrupt_thread, IRQF_SHARED,
> >  					"dwc3-omap", omap);
> > @@ -533,10 +532,10 @@ static int dwc3_omap_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	dwc3_omap_enable_irqs(omap);
> > -	enable_irq(omap->irq);
> >  	return 0;
> >  
> >  err1:
> > +	disable_irq(omap->irq);
> >  	pm_runtime_put_sync(dev);
> >  	pm_runtime_disable(dev);
> >  
> > 
> 
> -- 
> Regards
> Vignesh