linux-kernel - Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629071414.g4pmbmtegf7jpryz@gmail.com>
Date:   Thu, 29 Jun 2017 09:14:14 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        live-patching@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andy Lutomirski <luto@...nel.org>, Jiri Slaby <jslaby@...e.cz>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation


* Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> Now that objtool knows the states of all registers on the stack for each
> instruction, it's straightforward to generate debuginfo for an unwinder
> to use.
> 
> Instead of generating DWARF, generate a new format called undwarf, which
> is more suitable for an in-kernel unwinder.  See
> tools/objtool/Documentation/undwarf.txt for a more detailed description
> of this new debuginfo format and why it's preferable to DWARF.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> ---
>  tools/objtool/Build                              |   3 +
>  tools/objtool/Documentation/stack-validation.txt |  46 ++---
>  tools/objtool/builtin-check.c                    |   2 +-
>  tools/objtool/builtin-undwarf.c                  |  70 ++++++++
>  tools/objtool/builtin.h                          |   1 +
>  tools/objtool/check.c                            |  59 ++++++-
>  tools/objtool/check.h                            |  15 +-
>  tools/objtool/elf.c                              | 212 ++++++++++++++++++++--
>  tools/objtool/elf.h                              |  15 +-
>  tools/objtool/objtool.c                          |   3 +-
>  tools/objtool/undwarf-types.h                    |  81 +++++++++

Just a very quick stylistic suggestion: please name the header 'undwarf_types.h' 
(note the underscore versus hyphen), which is the common naming pattern used in 
the kernel.

Thanks,

	Ingo