linux-kernel - Re: [PATCH] module: make the modinfo name const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+ZUf9DeHCBoTjXRZ7uLUCi79pJtbj-XvtmtvSZwk7-6Q@mail.gmail.com>
Date:   Wed, 28 Jun 2017 18:34:25 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     Jessica Yu <jeyu@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] module: make the modinfo name const

On Wed, Jun 28, 2017 at 6:32 PM, Luis R. Rodriguez <mcgrof@...nel.org> wrote:
> This can be accomplished by makine blacklisted() also accept const.

Typo "making"

> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>

But otherwise:

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  kernel/module.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 5ebe3ae2519a..7d679f3bb892 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -302,7 +302,7 @@ int unregister_module_notifier(struct notifier_block *nb)
>  EXPORT_SYMBOL(unregister_module_notifier);
>
>  struct load_info {
> -       char *name;
> +       const char *name;
>         Elf_Ehdr *hdr;
>         unsigned long len;
>         Elf_Shdr *sechdrs;
> @@ -3382,7 +3382,7 @@ int __weak module_frob_arch_sections(Elf_Ehdr *hdr,
>
>  /* module_blacklist is a comma-separated list of module names */
>  static char *module_blacklist;
> -static bool blacklisted(char *module_name)
> +static bool blacklisted(const char *module_name)
>  {
>         const char *p;
>         size_t len;
> --
> 2.10.2
>



-- 
Kees Cook
Pixel Security