linux-kernel - Re: Spurious touchpad events with closed LID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629073102.GG25196@pali>
Date:   Thu, 29 Jun 2017 09:31:02 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Pavel Machek <pavel@....cz>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: Spurious touchpad events with closed LID

On Thursday 29 June 2017 00:44:27 Bastien Nocera wrote:
> On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote:
> > 
> <snip>
> > While policy normally belongs to userspace, I'd argue this is
> > workaround for a hardware bug, and in-kernel solution would be
> > acceptable.
> > 
> > Anyway, disable attribute would be nice first step.
> 
> It's already fixed for those of us on recent distributions. The
> "ID_INPUT_TOUCHPAD_INTEGRATION=internal" touchpads will be disabled
> when the lid is closed, when libinput is used to process the events.

But this does not fix other usage of /dev/input/* and also does not fix
pressing spurious keys in linux virtual tty (ctrl+alt+f1). So it is not
a fix.

Also important question is: How you detect which input device is
"internal", non-removable part of notebook and which one is external?

You can have external USB touchpad, and also you can have external PS/2
keyboard connected to docking station (which was e.g. my situation).

Also there are PS/2 to active USB converters, to make whole situation
complicated.

And moreover some internal notebook keyboards are connected via USB and
some touchpads via i2c/smbus.

I think this detection is not easy or at least I have no idea how to do
properly. Existence of PS/2 keyboard does not mean it is internal and
existence of USB keyboard does not mean it is external.

Maybe ACPI/DSDT provides some information? (No idea, just asking)

> Usually, non-crappy hardware will do that in firmware, but software is
> easier to patch ;)

-- 
Pali Rohár
pali.rohar@...il.com