linux-kernel - Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANRm+CyYiSAn+HnaDY=qJAx6HRFsKVyWmuUpQr50f1CaQQjVew@mail.gmail.com>
Date:   Thu, 29 Jun 2017 16:44:16 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvm <kvm@...r.kernel.org>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay

2017-06-29 16:17 GMT+08:00 Wanpeng Li <kernellwp@...il.com>:
> 2017-06-29 15:55 GMT+08:00 Paolo Bonzini <pbonzini@...hat.com>:
>>> +
>>> +            /* In case the sw timer triggered in the window */
>>> +            if (atomic_read(&apic->lapic_timer.pending) &&
>>> +                !apic_lvtt_period(apic))
>>> +                need_cancel = true;
>>> +            else if (r && (apic_lvtt_oneshot(apic) ||
>>> apic_lvtt_tscdeadline(apic)))
>>> +                apic_timer_expired(apic);
>>> +        }
>>> +    }
>
> [...]
>
>>
>> You still need to enable the preemption timer even if you return 1, so
>> in lapic.c it becomes
>>
>>         if (!apic_lvtt_period(apic)) {
>>                 if (r)
>>                         apic_timer_expired(apic);
>>                 if (atomic_read(&apic->lapic_timer.pending))
>>                         need_cancel = true;
>>         }
>
> I think the codes are more clear but the same as above. We didn't
> program preemption timer vmcs field if delta == 0, so how to
> understand "need to enable the preemption timer even if return 1"?

I guess you mean start_hv_timer() should return true, right?

Regards,
Wanpeng Li