linux-kernel - Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5954C262.9000502@iogearbox.net>
Date:   Thu, 29 Jun 2017 11:03:30 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Michael Ellerman <mpe@...erman.id.au>,
        kernel-hardening@...ts.openwall.com
CC:     keescook@...omium.org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, labbott@...hat.com
Subject: Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h

On 06/29/2017 08:29 AM, Michael Ellerman wrote:
> Currently code that wants to use set_memory_ro() etc, needs to include
> asm/set_memory.h, which doesn't exist on all arches. Some code knows
> it only builds on arches which have the header, other code guards the
> inclusion with an #ifdef, neither is ideal.
>
> So create linux/set_memory.h. This always exists, so users don't need
> an #ifdef just to include the header.
>
> When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h,
> otherwise it provides empty non-failing implementations.
>
> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>

Looks good to me, thanks!

Acked-by: Daniel Borkmann <daniel@...earbox.net>

I'm fine if Andrew or Kees picks up the bpf patch as well, I think
there shouldn't be any conflict with net-next on this one (and even
if so, then looks trivial to resolve).