linux-kernel - Re: [PATCH] char: ipmi: constify bmc_dev_attr_group and bmc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 20:55:27 -0500
From:   Corey Minyard <minyard@....org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: ipmi: constify bmc_dev_attr_group and
 bmc_device_type

Applied, thanks.

-corey

On 06/23/2017 12:13 AM, Arvind Yadav wrote:
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>    25678	   1024	     92	  26794	   68aa	drivers/char/ipmi/ipmi_msghandler.o
>
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>    25806	    896	     92	  26794	   68aa	drivers/char/ipmi/ipmi_msghandler.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>   drivers/char/ipmi/ipmi_msghandler.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 9f69995..d60c05c 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2397,7 +2397,7 @@ static umode_t bmc_dev_attr_is_visible(struct kobject *kobj,
>   	return mode;
>   }
>   
> -static struct attribute_group bmc_dev_attr_group = {
> +static const struct attribute_group bmc_dev_attr_group = {
>   	.attrs		= bmc_dev_attrs,
>   	.is_visible	= bmc_dev_attr_is_visible,
>   };
> @@ -2407,7 +2407,7 @@ static umode_t bmc_dev_attr_is_visible(struct kobject *kobj,
>   	NULL
>   };
>   
> -static struct device_type bmc_device_type = {
> +static const struct device_type bmc_device_type = {
>   	.groups		= bmc_dev_attr_groups,
>   };
>