linux-kernel - Re: [PATCH] PM: hibernate: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170629115941.GA11525@amd>
Date:   Thu, 29 Jun 2017 13:59:41 +0200
From:   Pavel Machek <pavel@....cz>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     rjw@...ysocki.net, len.brown@...el.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM: hibernate: constify attribute_group structures.

On Thu 2017-06-29 16:58:40, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    6332	    488	    308	   7128	   1bd8	kernel/power/hibernate.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    6396	    424	    308	   7128	   1bd8	kernel/power/hibernate.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Acked-by: Pavel Machek <pavel@....cz>


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)