linux-kernel - Re: [PATCH V4 04/12] kernfs: don't set dentry->d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629125104.GD26046@kroah.com>
Date:   Thu, 29 Jun 2017 14:51:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shaohua Li <shli@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        tj@...nel.org, hch@....de, axboe@...com, rostedt@...dmis.org,
        lizefan@...wei.com, Kernel-team@...com, Shaohua Li <shli@...com>
Subject: Re: [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata

On Wed, Jun 28, 2017 at 09:29:54AM -0700, Shaohua Li wrote:
> From: Shaohua Li <shli@...com>
> 
> When working on adding exportfs operations in kernfs, I found it's hard
> to initialize dentry->d_fsdata in the exportfs operations. Looks there
> is no way to do it without race condition. Look at the kernfs code
> closely, there is no point to set dentry->d_fsdata. inode->i_private
> already points to kernfs_node, and we can get inode from a dentry. So
> this patch just delete the d_fsdata usage.
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Shaohua Li <shli@...com>

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>