linux-kernel - Re: [PATCH] EDAC: Get rid of mci->mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <deade91d-7326-8a39-3881-50db582c3098@linux.intel.com>
Date:   Thu, 29 Jun 2017 08:57:57 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>,
        linux-edac <linux-edac@...r.kernel.org>
Cc:     Mark Gross <mark.gross@...el.com>,
        Robert Richter <rric@...nel.org>,
        Tim Small <tim@...tersideup.com>,
        Ranganathan Desikan <ravi@...ztechnologies.com>,
        "Arvind R." <arvino55@...il.com>, Jason Baron <jbaron@...mai.com>,
        Tony Luck <tony.luck@...el.com>,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        David Daney <david.daney@...ium.com>, Loc Ho <lho@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mips@...ux-mips.org
Subject: Re: [PATCH] EDAC: Get rid of mci->mod_ver

On 06/29/2017 05:03 AM, Borislav Petkov wrote:
> Hi,
> 
> any objections?
> 
> ---
> It is a write-only variable so get rid of it.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Thor Thayer <thor.thayer@...ux.intel.com>
> Cc: Mark Gross <mark.gross@...el.com>
> Cc: Robert Richter <rric@...nel.org>
> Cc: Tim Small <tim@...tersideup.com>
> Cc: Ranganathan Desikan <ravi@...ztechnologies.com>
> Cc: "Arvind R." <arvino55@...il.com>
> Cc: Jason Baron <jbaron@...mai.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: David Daney <david.daney@...ium.com>
> Cc: Loc Ho <lho@....com>
> Cc: linux-edac@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-mips@...ux-mips.org
> ---
>   drivers/edac/altera_edac.c      | 2 --

<snip>

> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index db75d4b614f7..fa2e5db56d24 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -38,7 +38,6 @@
>   #include "edac_module.h"
>   
>   #define EDAC_MOD_STR		"altera_edac"
> -#define EDAC_VERSION		"1"
>   #define EDAC_DEVICE		"Altera"
>   

<snip>

Looks fine for Altera EDAC.

Acked-by: Thor Thayer <thor.thayer@...ux.intel.com>