linux-kernel - Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45eba5b6-d5a2-1007-1af5-2a076dd0630e@ideasonboard.com>
Date:   Thu, 29 Jun 2017 15:07:55 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        linux-renesas-soc@...r.kernel.org, linux-media@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, laurent.pinchart@...asonboard.com
Cc:     David Airlie <airlied@...ux.ie>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips
 using the VSP1

> @@ -658,10 +660,14 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
>  	rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
>  
>  	if (status & DSSR_FRM) {
> -		drm_crtc_handle_vblank(&rcrtc->crtc);
> -
> -		if (rcdu->info->gen < 3)
> +		/*
> +		 * Gen 3 vblank and page flips are handled through the VSP
> +		 * completion handler
> +		 */
> +		if (rcdu->info->gen < 3) {

Of course as is obvious immediately after hitting send, this check was supposed
to be removed now that the interrupt is not registered.

Sorry for the noise and pre-released patch!

--
Kieran