linux-kernel - Re: [PATCH] staging: ccree: constify dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170629141745.GA29512@kroah.com>
Date:   Thu, 29 Jun 2017 16:17:45 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     lkp@...el.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ccree: constify dev_pm_ops structures.

On Thu, Jun 29, 2017 at 03:00:28PM +0530, Arvind Yadav wrote:
> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    3800	    488	      0	   4288	   10c0	drivers/staging/ccree/ssi_driver.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    4010	    288	      0	   4298	   10ca	drivers/staging/ccree/ssi_driver.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/staging/ccree/ssi_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

No longer applies to my staging-testing branch at all due to other
changes happening there.  Please rebase and resend.

thanks,

greg k-h