linux-kernel - Re: [PATCH] perf tools: set no branch type for dummy event in PT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629153932.GA2924@krava>
Date:   Thu, 29 Jun 2017 17:39:32 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Liang, Kan" <kan.liang@...el.com>
Cc:     "acme@...nel.org" <acme@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>
Subject: Re: [PATCH] perf tools: set no branch type for dummy event in PT

On Thu, Jun 29, 2017 at 03:31:45PM +0000, Liang, Kan wrote:

SNIP

> > >  static int intel_pt_recording_options(struct auxtrace_record *itr,
> > >  				      struct perf_evlist *evlist,
> > >  				      struct record_opts *opts)
> > > @@ -701,6 +717,8 @@ static int intel_pt_recording_options(struct
> > auxtrace_record *itr,
> > >  				perf_evsel__set_sample_bit(switch_evsel,
> > TIME);
> > >  				perf_evsel__set_sample_bit(switch_evsel,
> > CPU);
> > >
> > > +				add_no_lbr_config_term(&switch_evsel-
> > >config_terms);
> > > +
> > 
> > hum, why can't you change the sample bit directly? with:
> > 
> > 			perf_evsel__reset_sample_bit(switch_evsel,
> > BRANCH_STACK);
> 
> It will be overwrite in perf_evsel__config.
> 

where? you set the evsel->no_aux_samples 

jirka