linux-kernel - Re: [PATCH] kernel: ksysfs: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKza5-sMWUO7EK1jXw3=u+pZ+M3GVOD7z1+Q5KZSZ8mVg@mail.gmail.com>
Date:   Thu, 29 Jun 2017 09:14:42 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Russell King <rmk+kernel@....linux.org.uk>,
        Dave Young <dyoung@...hat.com>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Petr Tesarik <ptesarik@...e.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: ksysfs: constify attribute_group structures.

On Thu, Jun 29, 2017 at 5:01 AM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
>    text    data     bss     dec     hex filename
>    1120     544      16    1680     690 kernel/ksysfs.o
>
> File size After adding 'const':
>    text    data     bss     dec     hex filename
>    1160     480      16    1656     678 kernel/ksysfs.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks! Always nice to get more const structures. :)

Andrew, can you pick this up?

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  kernel/ksysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
> index 23cd706..df1a9aa 100644
> --- a/kernel/ksysfs.c
> +++ b/kernel/ksysfs.c
> @@ -234,7 +234,7 @@ static ssize_t notes_read(struct file *filp, struct kobject *kobj,
>         NULL
>  };
>
> -static struct attribute_group kernel_attr_group = {
> +static const struct attribute_group kernel_attr_group = {
>         .attrs = kernel_attrs,
>  };
>
> --
> 1.9.1
>



-- 
Kees Cook
Pixel Security