linux-kernel - [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170629165035.23101-2-enric.balletbo@collabora.com>
Date:   Thu, 29 Jun 2017 18:50:35 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Zhang Rui <rui.zhang@...el.com>, rjw@...ysocki.net,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Guenter Roeck <groeck@...omium.org>,
        Sameer Nanda <snanda@...omium.org>
Subject: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

Under each thermal zone there is a optional file called "mode". Writing
enabled or disabled to this file allows a given thermal zone to be enabled
or disabled, but in current code, the monitoring queue doesn't stops. Add
the code to disable polling when disabling thermal zone and enable polling
when enabling the thermal zone.

This patch is based on the original Sameer Nanda <snanda@...omium.org>
patch that implemented this idea for the ACPI thermal driver.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
---
Changes since v1:
 - Implement in thermal subsystem instead of ACPI thermal driver (Zhang Rui)

v1: https://patchwork.kernel.org/patch/9804229/

 drivers/thermal/thermal_core.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 5a51c74..869c8f3 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -292,6 +292,17 @@ static void thermal_unregister_governors(void)
 static void thermal_zone_device_set_polling(struct thermal_zone_device *tz,
 					    int delay)
 {
+	enum thermal_device_mode mode;
+
+	if (tz->ops->get_mode) {
+		/* When the thermal zone is disabled stop the polling */
+		tz->ops->get_mode(tz, &mode);
+		if (mode == THERMAL_DEVICE_DISABLED) {
+			cancel_delayed_work(&tz->poll_queue);
+			return;
+		}
+	}
+
 	if (delay > 1000)
 		mod_delayed_work(system_freezable_wq, &tz->poll_queue,
 				 round_jiffies(msecs_to_jiffies(delay)));
-- 
2.9.3