linux-kernel - Re: [PATCH 4.4 24/30] swap: cond_resched in swap_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1498757023.1935.57.camel@codethink.co.uk>
Date:   Thu, 29 Jun 2017 18:23:43 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Yu Zhao <yuzhao@...gle.com>,
        David Rientjes <rientjes@...gle.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Michal Hocko <mhocko@...e.com>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 4.4 24/30] swap: cond_resched in swap_cgroup_prepare()

On Mon, 2017-06-19 at 23:20 +0800, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Yu Zhao <yuzhao@...gle.com>
> 
> commit ef70762948dde012146926720b70e79736336764 upstream.
> 
> I saw need_resched() warnings when swapping on large swapfile (TBs)
> because continuously allocating many pages in swap_cgroup_prepare() took
> too long.
> 
> We already cond_resched when freeing page in swap_cgroup_swapoff().  Do
> the same for the page allocation.
[...]

That seems to imply that this should also go into stable branches:

commit 460bcec84e11c75122ace5976214abbc596eb91b
Author: David Rientjes <rientjes@...gle.com>
Date:   Fri Apr 7 16:05:00 2017 -0700

    mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()
    
Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.