linux-kernel - Re: [PATCH NET V7 0/2] Add loopback support in phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629182216.GB17212@lunn.ch>
Date:   Thu, 29 Jun 2017 20:22:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     David Miller <davem@...emloft.net>
Cc:     linyunsheng@...wei.com, f.fainelli@...il.com,
        huangdaode@...ilicon.com, xuwei5@...ilicon.com,
        liguozhu@...ilicon.com, Yisen.Zhuang@...wei.com,
        gabriele.paoloni@...wei.com, john.garry@...wei.com,
        linuxarm@...wei.com, salil.mehta@...wei.com, lipeng321@...wei.com,
        tremyfr@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns
 ethtool fix

On Thu, Jun 29, 2017 at 02:14:55PM -0400, David Miller wrote:
> From: Lin Yun Sheng <linyunsheng@...wei.com>
> Date: Wed, 28 Jun 2017 17:13:09 +0800
> 
> > This Patch Set add set_loopback in phy_driver and use it to setup loopback
> > when doing ethtool phy self_test.
> 
> This doesn't apply cleanly to the net-next tree, please respin.

Hi David

This patchset still has issues. The first patch is O.K. to be
committed, but the second patch to the hns driver still has issues. I
suppose it makes the hns driver less broken, but it is still
broken. Is less broken a sufficient criteria for acceptance?

	Andrew