linux-kernel - Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 11:45:21 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Support Opensource <support.opensource@...semi.com>,
        Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel

Hi Sebastian,

On Thu, Jun 29, 2017 at 02:43:46PM +0200, Sebastian Reichel wrote:
> @@ -238,6 +239,14 @@ static int da9052_ts_probe(struct platform_device *pdev)
>  	if (!da9052)
>  		return -EINVAL;
>  
> +	/*
> +	 * Check if touchscreen pins are used are analogue input instead
> +	 * of having a touchscreen connected to them. The analogue input
> +	 * functionality will be provided by hwmon driver (if enabled).
> +	 */
> +	if (device_property_read_bool(pdev->dev.parent, "dlg,tsi-as-adc"))
> +		return -ENODEV;
> +

I believe this is not the right way of doing this. da9052-core should
simply forgo creating da9052-tsi platform device when this property is
present.

Thanks.

-- 
Dmitry