linux-kernel - [patch 0/5] genirq: Distangle irq_request/release_resources() from irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170629213334.375848050@linutronix.de>
Date:   Thu, 29 Jun 2017 23:33:34 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Marc Zyngier <marc.zyngier@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Brian Norris <briannorris@...omium.org>,
        Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org,
        Julia Cartwright <julia@...com>, linux-gpio@...r.kernel.org,
        John Keeping <john@...anate.com>,
        Doug Anderson <dianders@...omium.org>
Subject: [patch 0/5] genirq: Distangle irq_request/release_resources() from
 irq_desc->lock

The irq_request/release_resources() callbacks are a problem on RT as they
are called under irq_desc->lock with interrupts disabled.

Aside of that calling them under irq_desc->lock is conceptually wrong and
has a (hard to trigger and probably theoretical) issue in free_irq(). See
patch 4/5 for a detailed explanation.

The series contains also a fix for the exynos gpio driver, which fiddles
with the irq masking in the resource callbacks, which is bogus and
potentially harmful.

Finally it moves the irq timings deallocation out of the spin locked region.

Thanks,

	tglx
---
 drivers/pinctrl/samsung/pinctrl-exynos.c |    4 --
 include/linux/irqdesc.h                  |    3 +
 kernel/irq/irqdesc.c                     |    1 
 kernel/irq/manage.c                      |   47 +++++++++++++++++++------------
 4 files changed, 34 insertions(+), 21 deletions(-)