linux-kernel - Re: Inconsistency in scripts/checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1498792351.2739.8.camel@perches.com>
Date:   Thu, 29 Jun 2017 20:12:31 -0700
From:   Joe Perches <joe@...ches.com>
To:     Larry Finger <Larry.Finger@...inger.net>,
        Andy Whitcroft <apw@...onical.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: Inconsistency in scripts/checkpatch.pl

On Thu, 2017-06-29 at 20:26 -0500, Larry Finger wrote:
> Andy and Joe,
> 
> In some new rtlwifi code, I get the following for one of the new macros:
> 
> CHECK: Macro argument '__h2c' may be better as '(__h2c)' to avoid precedence issues
> #45005: FILE: 
> drivers/net/wireless/realtek/rtlwifi/halmac/halmac_original_h2c_nic.h:1163:
> +#define AOAC_RSVD_PAGE3_GET_LOC_AOAC_REPORT(__h2c)                     \
> +       LE_BITS_TO_4BYTE(__h2c + 0X00, 16, 8)
> 
> When I make that change, I get
> 
> CHECK: No space is necessary after a cast
> #45004: FILE: 
> drivers/net/wireless/realtek/rtlwifi/halmac/halmac_original_h2c_nic.h:1162:
> +       LE_BITS_TO_4BYTE((__h2c) + 0X00, 16, 8)
> 
> Which CHECK should I fix?

The first.  Only if you want to.

>  To my eye, the second form is the false positive.

I agree.  Ignore the 2nd warning for awhile.
.
A few trivial notes:

o 0X00 is kinda ugly to me.  0x00 is nicer.
o I presume that 0x00 could be a #define somewhere
o AOAC_RSVD_PAGE3_GET_LOC_AOAC_REPORT is a rather
  long identifier at 35 chars.