linux-kernel - Re: [tip:x86/platform] x86/PCI/mmcfg: Switch to ECAM config mode if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170630031849.GP23705@tassilo.jf.intel.com>
Date:   Thu, 29 Jun 2017 20:18:49 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Yinghai Lu <yinghai@...nel.org>
Cc:     Stephane Eranian <eranian@...gle.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Matthew Wilcox <willy@...ux.intel.com>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/platform] x86/PCI/mmcfg: Switch to ECAM config mode if
 possible

> Hi Thomas,
> 
> Would this patch actually void the commit:

Yes it does. My origina; patches were opt-in for this reason, but Thomas doesn't
believe in historical or other people's experience.

But MCFG problems were a long time ago and noone uses these systems anymore,
so perhaps he is right.

-Andi

> 
> commit a0ca9909609470ad779b9b9cc68ce96e975afff7
> Author: Ivan Kokshaysky <ink@...assic.park.msu.ru>
> Date:   Mon Jan 14 17:31:09 2008 -0500
> 
>     PCI x86: always use conf1 to access config space below 256 bytes
> 
>     Thanks to Loic Prylli <loic@...i.com>, who originally proposed
>     this idea.
> 
>     Always using legacy configuration mechanism for the legacy config space
>     and extended mechanism (mmconf) for the extended config space is
>     a simple and very logical approach. It's supposed to resolve all
>     known mmconf problems. It still allows per-device quirks (tweaking
>     dev->cfg_size). It also allows to get rid of mmconf fallback code.
> 
>     Signed-off-by: Ivan Kokshaysky <ink@...assic.park.msu.ru>
>     Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
>     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>