linux-kernel - Re: [PATCH v3] staging: lustre: lnet: remove dead code and crc32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170630060120.GA29779@kroah.com>
Date:   Fri, 30 Jun 2017 08:01:20 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dmitriy Cherkasov <dmitriy@...-tech.org>
Cc:     devel@...verdev.osuosl.org, Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH v3] staging: lustre: lnet: remove dead code and
 crc32_le() wrapper

On Fri, Jun 30, 2017 at 03:52:46AM +0000, Dmitriy Cherkasov wrote:
> After removing code which was premanently disabled with ifdefs, the
> function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
> this useless wrapper and instead call crc32_le() directly.
> 
> This also resolves the following checkpatch warning which was
> triggered by the dead code:
> 
> WARNING: space prohibited before semicolon
> 
> Signed-off-by: Dmitriy Cherkasov <dmitriy@...-tech.org>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h     | 11 -----------
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++++++-------
>  2 files changed, 7 insertions(+), 18 deletions(-)

What changed from previous versions of this patch?  You need to put that
information below the --- line, as documented.

v4? :)

thanks,

greg k-h