linux-kernel - RE: [PATCH] staging: fsl-dpaa2/eth: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB5PR04MB1240A5870E15A372E3FEE3FBEAD30@DB5PR04MB1240.eurprd04.prod.outlook.com>
Date:   Fri, 30 Jun 2017 07:19:24 +0000
From:   Bogdan Purcareata <bogdan.purcareata@....com>
To:     Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "agraf@...e.de" <agraf@...e.de>, "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "stuyoder@...il.com" <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>
Subject: RE: [PATCH] staging: fsl-dpaa2/eth: Remove dead code

> -----Original Message-----
> From: Ioana Radulescu [mailto:ruxandra.radulescu@....com]
> Sent: Thursday, June 29, 2017 7:26 PM
> To: gregkh@...uxfoundation.org
> Cc: devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org;
> agraf@...e.de; arnd@...db.de; linux-arm-kernel@...ts.infradead.org; Bogdan
> Purcareata <bogdan.purcareata@....com>; stuyoder@...il.com; Laurentiu Tudor
> <laurentiu.tudor@....com>
> Subject: [PATCH] staging: fsl-dpaa2/eth: Remove dead code
> 
> All possible values of the switch statement are explicitly
> handled, so there's no need to have a default branch.
> 
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@....com>

Acked-by: Bogdan Purcareata <bogdan.purcareata@....com>

> ---
>  drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> index 5312edc26f01..031179ab3a22 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c
> @@ -217,8 +217,6 @@ static void dpaa2_eth_get_ethtool_stats(struct
> net_device *net_dev,
>  		case 2:
>  			num_cnt = sizeof(dpni_stats.page_2) / sizeof(u64);
>  			break;
> -		default:
> -			break;
>  		}
>  		for (k = 0; k < num_cnt; k++)
>  			*(data + i++) = dpni_stats.raw.counter[k];
> --
> 2.11.0