lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Jun 2017 17:01:13 -0700 From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> To: linux-kernel@...r.kernel.org Cc: netfilter-devel@...r.kernel.org, netdev@...r.kernel.org, oleg@...hat.com, akpm@...ux-foundation.org, mingo@...hat.com, dave@...olabs.net, manfred@...orfullife.com, tj@...nel.org, arnd@...db.de, linux-arch@...r.kernel.org, will.deacon@....com, peterz@...radead.org, stern@...land.harvard.edu, parri.andrea@...il.com, torvalds@...ux-foundation.org, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Ingo Molnar <mingo@...nel.org> Subject: [PATCH RFC 05/26] exit: Replace spin_unlock_wait() with lock/unlock pair There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_exit() with spin_lock() followed immediately by spin_unlock(). This should be safe from a performance perspective because the lock is a per-task lock, and this is happening only at task-exit time. Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> Cc: Ingo Molnar <mingo@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Will Deacon <will.deacon@....com> Cc: Alan Stern <stern@...land.harvard.edu> Cc: Andrea Parri <parri.andrea@...il.com> Cc: Linus Torvalds <torvalds@...ux-foundation.org> --- kernel/exit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/exit.c b/kernel/exit.c index 516acdb0e0ec..1a976e47ddd1 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -832,7 +832,8 @@ void __noreturn do_exit(long code) * Ensure that we must observe the pi_state in exit_mm() -> * mm_release() -> exit_pi_state_list(). */ - raw_spin_unlock_wait(&tsk->pi_lock); + raw_spin_lock(&tsk->pi_lock); + raw_spin_unlock(&tsk->pi_lock); if (unlikely(in_atomic())) { pr_info("note: %s[%d] exited with preempt_count %d\n", -- 2.5.2
Powered by blists - more mailing lists