linux-kernel - Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shihpwn9.fsf@concordia.ellerman.id.au>
Date:   Fri, 30 Jun 2017 21:01:14 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Fathi Boudra <fathi.boudra@...aro.org>
Cc:     linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
Subject: Re: [PATCH 1/1] selftests: gpio: use pkg-config to determine libmount CFLAGS/LDLIBS

Fathi Boudra <fathi.boudra@...aro.org> writes:

> On 29 June 2017 at 12:01, Michael Ellerman <mpe@...erman.id.au> wrote:
>> Fathi Boudra <fathi.boudra@...aro.org> writes:
>>
>>> Fix hardcoded and misplaced libmount headers. Use pkg-config instead to
>>> figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation.
>>
>> Can you explain how it fixes the values for cross-compilation?
>
> When pkg-config is invoked in a cross-build environment, it will
> return your sysroot headers path instead of the hardcoded
> -I/usr/include/libmount
>
> For example in my oe environment, when I invoke "pkg-config --cflags
> mount", it returns:
> -I/build/tmp-rpb-glibc/sysroots/hikey/usr/include/libmount

Right, presumably because OE is setting PKG_CONFIG_SYSROOT_DIR etc.

So for folks doing it by hand it doesn't really help with cross
compiling, but I guess it doesn't hurt either.

cheers