linux-kernel - Re: [PATCH 5/5] ARM: dts: sama5d27_som1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f204f169-1939-31cc-05af-8a715b86e082@microchip.com>
Date:   Fri, 30 Jun 2017 15:28:51 +0300
From:   m18063 <Claudiu.Beznea@...rochip.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Baruch Siach <baruch@...s.co.il>
CC:     <nicolas.ferre@...rochip.com>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <linux@...linux.org.uk>, <sza@....hu>,
        <devicetree@...r.kernel.org>, <cristian.birsan@...rochip.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK
 support

Hi Baruch, Alexandre

On 29.06.2017 15:16, Alexandre Belloni wrote:
> On 29/06/2017 at 14:59:31 +0300, Baruch Siach wrote:
>> Hi Claudiu,
>>
>> On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote:
>>> Add specifig DTS files and bindings for sama5d27 SoM1 EK board.
>>
>> Is there any publicly available information on this SoM?
>>
>> One more comment below.
>>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
>>> Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
>>> ---
>>
>> [snip]
>>
>>> +	memory {
>>> +		reg = <0x20000000 0x20000>;
>>
>> Are you sure this SoM has 132KB RAM?
Yes, here is a mistake, the size is 128MB. Sorry for the noise.
>>
>> Since you seem to rely on the bootloader to fill in the right size value, you 
>> can just drop this node and rely on sama5d2.dtsi that provides a stub node.
>>
> 
> Yeah, that is what I would do too.
Ok, I will do it so in v2.

Thank you,
Claudiu
> 
>