linux-kernel - Re: [PATCH] fs: GFS2: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1521062963.27753093.1498830143169.JavaMail.zimbra@redhat.com>
Date:   Fri, 30 Jun 2017 09:42:23 -0400 (EDT)
From:   Bob Peterson <rpeterso@...hat.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     swhiteho@...hat.com, torvalds@...ux-foundation.org,
        cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: GFS2: constify attribute_group structures.

----- Original Message -----
| attribute_groups are not supposed to change at runtime. All functions
| working with attribute_groups provided by <linux/sysfs.h> work with const
| attribute_group. So mark the non-const structs as const.
| 
| File size before:
|    text	   data	    bss	    dec	    hex	filename
|    5259	   1344	      8	   6611	   19d3	fs/gfs2/sys.o
| 
| File size After adding 'const':
|    text	   data	    bss	    dec	    hex	filename
|    5371	   1216	      8	   6595	   19c3	fs/gfs2/sys.o
| 
| Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Hi,

Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:

1fc2e87 GFS2: constify attribute_group structures.

Regards,

Bob Peterson
Red Hat File Systems