linux-kernel - Re: [PATCH] crypto: ccp-platform: print error message on platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd383386-bdd1-c91a-09de-8c67d4503168@amd.com>
Date:   Fri, 30 Jun 2017 10:08:00 -0500
From:   Gary R Hook <gary.hook@....com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: ccp-platform: print error message on
 platform_get_irq failure

On 06/30/2017 12:59 AM, Gustavo A. R. Silva wrote:
> Print error message on platform_get_irq failure before return.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/crypto/ccp/ccp-platform.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-platform.c
> b/drivers/crypto/ccp/ccp-platform.c
> index e26969e..6020c4a 100644
> --- a/drivers/crypto/ccp/ccp-platform.c
> +++ b/drivers/crypto/ccp/ccp-platform.c
> @@ -66,8 +66,10 @@ static int ccp_get_irq(struct ccp_device *ccp)
>          int ret;
>
>          ret = platform_get_irq(pdev, 0);
> -       if (ret < 0)
> +       if (ret < 0) {
> +               dev_notice(dev, "unable to get IRQ (%d)\n", ret);
>                  return ret;
> +       }

Good find.

I'm all for better and more messages, but I'd like to see more detail 
here, and in the
later dev_notice(). Can we have the messages better reflect the failure 
points?

>
>          ccp->irq = ret;
>          ret = request_irq(ccp->irq, ccp->vdata->perform->irqhandler, 0,
> --
> 2.5.0
>