linux-kernel - Re: [PATCH] usb: typec: include linux/device.h in ucsi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d4a8cfd-55c5-83f3-8b33-7587abbae135@roeck-us.net>
Date:   Fri, 30 Jun 2017 08:53:55 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...db.de>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: include linux/device.h in ucsi.h

On 06/30/2017 08:46 AM, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
> 
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
>                   from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This includes the required header file.
> 
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/usb/typec/ucsi/ucsi.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
>   #define __DRIVER_USB_TYPEC_UCSI_H
>   
>   #include <linux/bitops.h>
> +#include <linux/device.h>
>   #include <linux/types.h>
>   
>   /* -------------------------------------------------------------------------- */
>