linux-kernel - Re: [PATCH 0/4] Convert to TAP13 using ksft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fb6618f-7f39-dd6b-07bb-0e7e9929e6e1@pitt.edu>
Date:   Sat, 1 Jul 2017 01:13:35 +0900
From:   Paul Elder <paul.elder@...t.edu>
To:     Shuah Khan <shuahkh@....samsung.com>, shuah@...nel.org,
        alice.ferrazzi@...il.com, gregkh@...uxfoundation.org,
        labath@...gle.com, panand@...hat.com, will.deacon@....com
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Convert to TAP13 using ksft_ var arg msg api

On 06/30/2017 08:18 AM, Shuah Khan wrote:
> This patch series converts breakpoint_test_arm64 to TAP13 output. Uses
> ksft_ var arg msg functions as needed. Changed to ensure parent is the
> one that increments test counters.
> 
> breakpoint_test, step_after_suspend_test, membarrier tests are changed
> to use ksft_ var arg msg functions as needed.
> 
> This patch series depends on Paul Elder's
> 
> [PATCH v2 0/2] kselftest: make ksft_* output functions variadic
> The v2 series doesn't append newline and makes it easier to use.
> 
> Shuah Khan (4):
>   selftests: breakpoint_test: use ksft_* var arg msg api
>   selftests: breakpoints: step_after_suspend_test use ksft_* var arg msg
>     api
>   selftests: breakpoints: breakpoint_test_arm64: convert test to use
>     TAP13
>   selftests: membarrier: use ksft_* var arg msg api
> 
>  .../selftests/breakpoints/breakpoint_test.c        | 28 ++++---
>  .../selftests/breakpoints/breakpoint_test_arm64.c  | 94 +++++++++++++---------
>  .../breakpoints/step_after_suspend_test.c          | 59 ++++++++------
>  .../testing/selftests/membarrier/membarrier_test.c | 91 ++++++++++-----------
>  4 files changed, 148 insertions(+), 124 deletions(-)
> 
Looks good to me.

Although I am wondering why you said earlier that you were going to go with
my v1, while this depends on v2.

Thank you,

Paul