linux-kernel - Re: [PATCH] sgi-xp: convert BUG_ONs to WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPp3RGokdyahjg9xmFw-BWQiROdyYJ7xxbHdmu83nhtwQtaWXw@mail.gmail.com>
Date:   Fri, 30 Jun 2017 12:57:39 -0500
From:   Robin Holt <robinmholt@...il.com>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Cliff Whickman <cpw@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH] sgi-xp: convert BUG_ONs to WARN_ONs... sheesh

On Fri, Jun 30, 2017 at 12:01 PM, Davidlohr Bueso <dave@...olabs.net> wrote:
> While going through the driver wake code, I found the
> abuse of BUG_ON to be quite disturbing.

These were coded as BUG_ON to ensure they were addressed.  They
do not get raised in any running environment.  Switching to WARN_ON
will make it more difficult to determine that a problem has occurred and
with a large system, the details of that failure can easily get buried.

Those are my objections.  In reality, they are extremely rare and we can
easily switch these back to BUG_ON() when we are trying out new releases
and live with a WARN_ON() for other instances.

> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
Ackd-by: Robin Holt <robinmholt@...il.com>