linux-kernel - Re: [PATCH] libnvdimm, btt: fix btt_rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4iyy-Q7UMRoV8KQfLBL1Y2MZjOdNusSijJ7VCxFQmUQfw@mail.gmail.com>
Date:   Thu, 29 Jun 2017 18:32:48 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Vishal Verma <vishal.l.verma@...el.com>
Cc:     "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Toshi Kani <toshi.kani@....com>, Jeff Moyer <jmoyer@...hat.com>
Subject: Re: [PATCH] libnvdimm, btt: fix btt_rw_page not returning errors

On Thu, Jun 29, 2017 at 3:59 PM, Vishal Verma <vishal.l.verma@...el.com> wrote:
> btt_rw_page was not propagating errors frm btt_do_bvec, resulting in any
> IO errors via the rw_page path going unnoticed. the pmem driver recently
> fixed this in e10624f pmem: fail io-requests to known bad blocks
> but same problem in BTT went neglected.
>
> Fixes: 5212e11 nd_btt: atomic sector updates
> Cc: <stable@...r.kernel.org>
> Cc: Toshi Kani <toshi.kani@....com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Jeff Moyer <jmoyer@...hat.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@...el.com>
> ---
>  drivers/nvdimm/btt.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index 7ca11df..4e56e72 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1248,10 +1248,13 @@ static int btt_rw_page(struct block_device *bdev, sector_t sector,
>                 struct page *page, bool is_write)
>  {
>         struct btt *btt = bdev->bd_disk->private_data;
> +       int rc;
>
> -       btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector);
> -       page_endio(page, is_write, 0);
> -       return 0;
> +       rc = btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector);
> +       if (rc == 0)
> +               page_endio(page, is_write, 0);
> +
> +       return rc;
>  }

Looks obviously correct, applied.