linux-kernel - Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Jun 2017 14:08:02 -0700
From:   sathyanarayanan kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@...il.com>
Subject: Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO
 driver

Hi Andy,

On 06/30/2017 01:51 PM, Andy Shevchenko wrote:
> If we are going to rename (which I personally consider as a good
> idea), this should follow it, and not otherwise.
I am having second thoughts about the rename. After going through the 
spec documents, I found that there are two main differences between CHT 
and BXT PMIC GPIO controllers.

1. BXT variant has 3 GPIO banks where as CHT variant has only 2 GPIO banks.
2. GPIO I/O control register and IRQ register mapping addresses are 
different in both BXT and CHT variants.

Given above differences, I think we have a choice to use the current 
driver and pass the above data difference to driver via .driver_data or 
platform_data. This is a bit messy method because we are not getting the 
register address or info about number of gpio banks from BIOS.

Other solution is to rename the existing driver to gpio-bxt-wcove.c and 
create a new one for CHT (if required).

Let me know your comments.

-- 
Sathyanarayanan Kuppuswamy
Linux kernel developer