lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1498877297.2353.10.camel@perches.com>
Date:   Fri, 30 Jun 2017 19:48:17 -0700
From:   Joe Perches <joe@...ches.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: seq_file optimization?

About this commit in mm:

---------------------------------------------------
commit c1aca87fb3f84a813fb3dda656bbee583c9c87a3
Author: Alexey Dobriyan <adobriyan@...il.com>
Date:   Fri Jun 30 11:02:04 2017 +1000

    fs/seq_file.c: delete small-value optimization
    
    num_to_str() optimizes printing small integers [0..9], so the same check
    higher in callchain is unnecessary.
---------------------------------------------------

Is removing this optimization really the same speed?

I don't think so.

The num_to_str call still does multiple moves of
memory to the output, this is a single byte copy.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ